This repository was archived by the owner on Nov 20, 2024. It is now read-only.
migrate to analyzer 2.8.0 #3077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srawlins
reviewed
Nov 29, 2021
| rule.reportLint(identifier); | ||
| var expression = node.expression; | ||
| if (expression.isSynthetic) return; | ||
| if (expression is Identifier && expression.staticElement == null) { |
There was a problem hiding this comment.
+1 thanks for the pre-fix!
scheglov
approved these changes
Nov 29, 2021
bwilkerson
reviewed
Nov 29, 2021
| // Update to `SUPER_INVOCATION_NOT_LAST` when analyzer 2.8.0+ is published | ||
| // https://github.com/dart-lang/linter/issues/3069 | ||
| // error(CompileTimeErrorCode.INVALID_SUPER_INVOCATION, 84, 5), | ||
| error(CompileTimeErrorCode.SUPER_INVOCATION_NOT_LAST, 84, 5), |
There was a problem hiding this comment.
Was this suppose to replace line 36? If both are currently being supported, should we stop reporting the lint when the error is being reported?
There was a problem hiding this comment.
I think the real answer is we remove the lint. It's been deprecated for a while...
See also: https://github.com/dart-lang/linter/issues/1368#issuecomment-455253837
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 23, 2023
* migrate to analyzer 2.8.0 * fix test expectations
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dart-lang/sdk#58572
/cc @scheglov @bwilkerson
/fyi @srawlins