migrate to analyzer 2.8.0 (#3077)

* migrate to analyzer 2.8.0

* fix test expectations

Author: pq

lib/src/rules/comment_references.dart

@@ -95,9 +95,10 @@ class _Visitor extends SimpleAstVisitor<void> {
 
   @override
   void visitCommentReference(CommentReference node) {
-    var identifier = node.identifier;
-    if (!identifier.isSynthetic && identifier.staticElement == null) {
-      rule.reportLint(identifier);
+    var expression = node.expression;
+    if (expression.isSynthetic) return;
+    if (expression is Identifier && expression.staticElement == null) {
+      rule.reportLint(expression);
     }
   }
 

pubspec.yaml

@@ -12,7 +12,7 @@ environment:
   sdk: '>=2.12.0 <3.0.0'
 
 dependencies:
-  analyzer: '>=2.7.0 <3.0.0'
+  analyzer: '>=2.8.0 <3.0.0'
   args: ^2.0.0
   collection: ^1.15.0
   glob: ^2.0.0

test/integration/secure_pubspec_urls.dart

@@ -37,9 +37,10 @@ void main() {
           stringContainsInOrder([
             'pubspec.yaml 4:11 [lint] The url should only only use secure protocols.',
             'pubspec.yaml 14:12 [lint] The url should only only use secure protocols.',
+            'pubspec.yaml 19:13 [lint] The url should only only use secure protocols.',
             'pubspec.yaml 27:12 [lint] The url should only only use secure protocols.',
             'pubspec.yaml 31:12 [lint] The url should only only use secure protocols.',
-            '1 file analyzed, 4 issues found',
+            '1 file analyzed, 5 issues found',
           ]));
       expect(exitCode, 1);
     });

test/mocks.dart

@@ -111,9 +111,6 @@ class MockSource extends BasicSource {
   @override
   TimestampedData<String> get contents => TimestampedData<String>(0, '');
 
-  @override
-  UriKind get uriKind => UriKind.FILE_URI;
-
   @override
   bool exists() => false;
 

test/rules/super_goes_last.dart

@@ -17,7 +17,6 @@ class SuperGoesLastTest extends LintRuleTest {
   @override
   String get lintRule => 'super_goes_last';
 
-  @FailingTest(issue: 'https://github.com/dart-lang/linter/issues/3069')
   test_invalidSuperInvocation() async {
     await assertDiagnostics(r'''
 class A {
@@ -33,9 +32,7 @@ class C extends A {
 
 ''', [
       error(HintCode.UNUSED_FIELD, 61, 2),
-      // Update to `SUPER_INVOCATION_NOT_LAST` when analyzer 2.8.0+ is published
-      // https://github.com/dart-lang/linter/issues/3069
-      // error(CompileTimeErrorCode.INVALID_SUPER_INVOCATION, 84, 5),
+      error(CompileTimeErrorCode.SUPER_INVOCATION_NOT_LAST, 84, 5),
       lint('super_goes_last', 84, 8),
     ]);
   }