Skip to content
This repository was archived by the owner on Nov 20, 2024. It is now read-only.

Implement FAILING tests #2837

Closed
wants to merge 2 commits into from
Closed

Conversation

asashour
Copy link
Contributor

@asashour asashour commented Jul 30, 2021

Fixes dart-lang/sdk#58468

To test

Select any current rule test, e.g.

currentlyLinting(); //LINT
currentlyOk(); //OK

Change the expectations to the below, and the tests are still green.

// this is for false positive cases, means it should be ok, but `unfortunately` currently lints
currentlyLinting(); // OK FAILING
// this is for false negative ones, meaning it should lint, but `unfortunately` currently is ok
currentlyOk(); // LINT FAILING

If the FAILING ones actually pass, there is a message printed about the succession.

// this fails the build and gives a message that it actually works
currentlyLinting(); // LINT FAILING
// this fails the build and gives a message that it actually works
currentlyOk(); // OK FAILING

@google-cla google-cla bot added the cla: yes label Jul 30, 2021
@coveralls
Copy link

coveralls commented Jul 30, 2021

Coverage Status

Coverage decreased (-0.06%) to 93.913% when pulling 590f38c on asashour:2815_failing into def6bf2 on dart-lang:master.

@srawlins
Copy link
Contributor

CC @bwilkerson I think we will be moving to the unit-test-style tests, instead of the e2e tests, especially for cases where we need to mark a "failing test case".

@bwilkerson
Copy link
Contributor

Agreed. That's our plan.

@srawlins srawlins closed this Oct 24, 2022
@asashour asashour deleted the 2815_failing branch October 25, 2022 06:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

Add a way to mark a failed test case
4 participants