Skip to content
This repository was archived by the owner on Nov 20, 2024. It is now read-only.

allow underscores for constructor names #2041

Merged
merged 1 commit into from
Mar 22, 2020
Merged

allow underscores for constructor names #2041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/src/rules/non_constant_identifier_names.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,9 @@ class _Visitor extends SimpleAstVisitor<void> {

@override
void visitConstructorDeclaration(ConstructorDeclaration node) {
checkIdentifier(node.name);
// For rationale on accepting underscores, see:
// https://github.com/dart-lang/linter/issues/1854
checkIdentifier(node.name, underscoresOk: true);
}

@override
Expand Down
5 changes: 4 additions & 1 deletion test/rules/non_constant_identifier_names.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,16 @@ abstract class A {
A(this.bar_bar); //OK
A.N(this.bar_bar); //OK
A.Named(this.bar_bar); //LINT
factory A.Named2(a) = A; //LINT
factory A.Named2(String a) = A; //LINT
A._Named(this.bar_bar); //LINT
A.named_bar(this.bar_bar); //LINT
A.namedBar(this.bar_bar); //OK
A._N(this.bar_bar); //LINT
A._named(this.bar_bar); //OK
A.$Named(this.bar_bar); //OK
A._(this.bar_bar); //OK
A.__(this.bar_bar); //OK
A.___(this.bar_bar); //OK

String foo_bar(); //LINT

Expand Down