Skip to content
This repository was archived by the owner on Nov 20, 2024. It is now read-only.

More allowances in unnecessary_parenthesis #1389

Merged
merged 1 commit into from
Jan 24, 2019
Merged

More allowances in unnecessary_parenthesis #1389

merged 1 commit into from
Jan 24, 2019

Conversation

srawlins
Copy link
Contributor

@srawlins
Copy link
Contributor Author

CC @a14n, lemme know what you think. I'd be very happy to add more test cases if you are worried about this becoming too permissive.

a14n
a14n approved these changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@a14n a14n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pq
pq approved these changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

@srawlins srawlins merged commit c91b897 into dart-archive:master Jan 24, 2019
@srawlins srawlins deleted the cascade-allowances branch January 24, 2019 17:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
3 more reviewers

@pq pq pq approved these changes

@a14n a14n a14n approved these changes

@bwilkerson bwilkerson bwilkerson approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@srawlins @pq @a14n @bwilkerson @googlebot