MAINT: unpin mypy #900
Open
MAINT: unpin mypy #900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `mypy` `1.0.0` was released on Feb. 6/2023, and we recently pinned it down to older versions while working on more important things because we had a few new type hinting issues pop up * fix the type hinting issues, which were actually just ignore directives on `try/except` blocks that are no longer needed, so that's a clear win I think * I doubt it matters much for us, but `mypy 1.0.0` can be ~40 % faster on large codebases: https://mypy-lang.blogspot.com/2023/02/mypy-10-released.html
|
Ah, confusingly the issue does still exist on It just didn't show up when I tested with Python |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mypy1.0.0was released on Feb. 6/2023, and we recently pinned it down to older versions while working on more important things because we had a few new type hinting issues pop upfix the type hinting issues, which were actually just ignore directives on
try/exceptblocks that are no longer needed, so that's a clear win I thinkI doubt it matters much for us, but
mypy 1.0.0can be ~40 % faster on large codebases:https://mypy-lang.blogspot.com/2023/02/mypy-10-released.html