fix(should-specify-forbid-unknown-values): align references #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SchroederSteffen
changed the title
| https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-18413 | ||
| https://github.com/typestack/class-validator/issues/438 | ||
| There is a CVE for class-transformer when using random javascript objects. You need to be careful about configuring the ValidationPipe in NestJs. | ||
| See <https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-18413>, <https://github.com/typestack/class-validator/issues/438> & <https://github.com/nestjs/nest/issues/10683>. |
There was a problem hiding this comment.
added link to the nestjs issue which explains that NestJs sets the default to false again (overwriting the class-validator default).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the rule
should-specify-forbid-unknown-valuesis sometimes calledvalidation-pipe-should-forbid-unknownorvalidation-pipe-should-use-forbid-unknown. Currently, even the rule docs link in the README is broken because of that.This PR aligns all references to
should-specify-forbid-unknown-values.