-
Notifications
You must be signed in to change notification settings - Fork 223
Centralize Maven dependency version management #1564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add missing version properties to parent POM - Convert hardcoded dependency versions to properties in parent dependencyManagement - Remove hardcoded versions from child modules - Add missing dependencies to parent dependencyManagement - Ensure all shared dependencies inherit versions from parent Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
|
@dapr/approvers-java-sdk could you please take a look. My only concern is Java Durable Task Client dependency that uses a weird version on Jackson. @javier-aliaga it would be good if you could take a look. @salaboy and @cicoyle I am not sure what should we do to get rid of |
Signed-off-by: Artur Ciocanu <[email protected]>
siri-varma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR ! This will make our dependency management easier
|
Thanks @artur-ciocanu ! LGTM. I think the required check is in a configuration section but I do not have access. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1564 +/- ##
============================================
+ Coverage 76.91% 78.51% +1.59%
- Complexity 1592 1912 +320
============================================
Files 145 215 +70
Lines 4843 5827 +984
Branches 562 649 +87
============================================
+ Hits 3725 4575 +850
- Misses 821 914 +93
- Partials 297 338 +41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
* adding new method signature plus test Signed-off-by: salaboy <[email protected]> * re adding imports Signed-off-by: salaboy <[email protected]> * fixing style Signed-off-by: salaboy <[email protected]> * checking empty metadata Signed-off-by: salaboy <[email protected]> * copy meta for safety and check if key is present Signed-off-by: salaboy <[email protected]> * Centralize Maven dependency version management (#1564) Signed-off-by: salaboy <[email protected]> * Fix dependencies multi app build and add proper test deps (#1572) * Force Jackson version to override the SB Jackson version Signed-off-by: Artur Ciocanu <[email protected]> * Move all the Jackson deps to parent POM. Signed-off-by: Artur Ciocanu <[email protected]> * Ensure app JAR build order Signed-off-by: Artur Ciocanu <[email protected]> * Remove explicit Jackson from sdk-tests module. Signed-off-by: Artur Ciocanu <[email protected]> * Make sure <scope>test</scope> is used for test dependencies. Signed-off-by: Artur Ciocanu <[email protected]> * Remove extra Jackson modules. Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]> * reverting pom Signed-off-by: salaboy <[email protected]> * fix codestyle Signed-off-by: salaboy <[email protected]> * using metaCopy Signed-off-by: salaboy <[email protected]> --------- Signed-off-by: salaboy <[email protected]> Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: artur-ciocanu <[email protected]>
Description
dependencyManagementdependencyManagementIssue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
This PR is trying to address this issue: #1565
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: