Skip to content

Conversation

@artur-ciocanu
Copy link
Contributor

@artur-ciocanu artur-ciocanu commented Sep 26, 2025

Description

  • Add missing version properties to parent POM
  • Convert hardcoded dependency versions to properties in parent dependencyManagement
  • Remove hardcoded versions from child modules
  • Add missing dependencies to parent dependencyManagement
  • Ensure all shared dependencies inherit versions from parent

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

This PR is trying to address this issue: #1565

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

- Add missing version properties to parent POM
- Convert hardcoded dependency versions to properties in parent dependencyManagement
- Remove hardcoded versions from child modules
- Add missing dependencies to parent dependencyManagement
- Ensure all shared dependencies inherit versions from parent

Signed-off-by: Artur Ciocanu <[email protected]>
@artur-ciocanu artur-ciocanu requested review from a team as code owners September 26, 2025 18:06
@artur-ciocanu
Copy link
Contributor Author

@dapr/approvers-java-sdk could you please take a look.

My only concern is Java Durable Task Client dependency that uses a weird version on Jackson.

@javier-aliaga it would be good if you could take a look.

@salaboy and @cicoyle I am not sure what should we do to get rid of Spring Boot 3.3 check. Do we have to change something in the GitHub Actions config?

Copy link
Contributor

@siri-varma siri-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR ! This will make our dependency management easier

@javier-aliaga
Copy link
Contributor

Thanks @artur-ciocanu ! LGTM. I think the required check is in a configuration section but I do not have access.

@artur-ciocanu artur-ciocanu merged commit 222b9a0 into dapr:master Oct 2, 2025
10 checks passed
@artur-ciocanu artur-ciocanu deleted the maven-improvements branch October 2, 2025 16:45
@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.51%. Comparing base (d759c53) to head (3ddc4df).
⚠️ Report is 228 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1564      +/-   ##
============================================
+ Coverage     76.91%   78.51%   +1.59%     
- Complexity     1592     1912     +320     
============================================
  Files           145      215      +70     
  Lines          4843     5827     +984     
  Branches        562      649      +87     
============================================
+ Hits           3725     4575     +850     
- Misses          821      914      +93     
- Partials        297      338      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

salaboy pushed a commit to salaboy/java-sdk that referenced this pull request Oct 24, 2025
salaboy pushed a commit to salaboy/java-sdk that referenced this pull request Oct 24, 2025
salaboy pushed a commit to salaboy/java-sdk that referenced this pull request Oct 24, 2025
salaboy pushed a commit to salaboy/java-sdk that referenced this pull request Oct 24, 2025
salaboy pushed a commit to salaboy/java-sdk that referenced this pull request Oct 24, 2025
salaboy pushed a commit to salaboy/java-sdk that referenced this pull request Oct 24, 2025
salaboy pushed a commit to salaboy/java-sdk that referenced this pull request Oct 24, 2025
dapr-bot pushed a commit that referenced this pull request Oct 24, 2025
* adding new method signature plus test

Signed-off-by: salaboy <[email protected]>

* re adding imports

Signed-off-by: salaboy <[email protected]>

* fixing style

Signed-off-by: salaboy <[email protected]>

* checking empty metadata

Signed-off-by: salaboy <[email protected]>

* copy meta for safety and check if key is present

Signed-off-by: salaboy <[email protected]>

* Centralize Maven dependency version management (#1564)

Signed-off-by: salaboy <[email protected]>

* Fix dependencies multi app build and add proper test deps (#1572)

* Force Jackson version to override the SB Jackson version

Signed-off-by: Artur Ciocanu <[email protected]>

* Move all the Jackson deps to parent POM.

Signed-off-by: Artur Ciocanu <[email protected]>

* Ensure app JAR build order

Signed-off-by: Artur Ciocanu <[email protected]>

* Remove explicit Jackson from sdk-tests module.

Signed-off-by: Artur Ciocanu <[email protected]>

* Make sure <scope>test</scope> is used for test dependencies.

Signed-off-by: Artur Ciocanu <[email protected]>

* Remove extra Jackson modules.

Signed-off-by: Artur Ciocanu <[email protected]>

---------

Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: salaboy <[email protected]>

* reverting pom

Signed-off-by: salaboy <[email protected]>

* fix codestyle

Signed-off-by: salaboy <[email protected]>

* using metaCopy

Signed-off-by: salaboy <[email protected]>

---------

Signed-off-by: salaboy <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Co-authored-by: artur-ciocanu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants