-
Notifications
You must be signed in to change notification settings - Fork 780
Python SDK workflow updates #4563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…o python sdk Signed-off-by: Hannah Hunter <[email protected]>
|
Stale PR, paging all reviewers |
daprdocs/content/en/developing-applications/building-blocks/workflow/howto-author-workflow.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Hannah Hunter <[email protected]>
|
This is correct for Python, however the manage Workflows article to Schedule a new workflow are wrong for .NET and for Go still and need updating in the same way that you updated the Python ones from start to scheduleNewWorkflow So this .NET sample should be changed (best to ask @WhitWaldo ) Look at the examples here https://github.com/dapr/dotnet-sdk/tree/master/examples/Workflow, but actually they all need to change since they have Workflow Component that is not correct. Hopefully Whit can help. And the Go Sample should be replaced by the example here https://github.com/dapr/go-sdk/blob/main/examples/workflow/main.go (without the test cases) entirely In both cases, need to also change the names of the APIs in that section from Start to ScheduleNewWorkflow (.NET does not have a list of APIs like the other language have) Note that the Javascript one is still |
Created new docs issues from this comment - might be best to focus in a separate PR so we can finally close out this Python issue! |
|
@msfussell I'm going to hold off on updating the docs for JS for right now as they're pretty inconsistent with the other languages. Once I get those changes merged, I'll revisit this. |
msfussell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Extra item:
Issue reference
PR will close: #4410