comment stakes needed to preboost/unpreboost #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jellegerbrandy
previously approved these changes
Mar 9, 2020
src/proposal.ts
Outdated
| * | ||
| * The equation is derived from: threshold = (stakesFor + upstakeNeededToPreBoost) / stakesAgainst | ||
| * | ||
| * >= 0 : any number of up-staking tokens greater than this will qualify to move the proposal |
Contributor
There was a problem hiding this comment.
I do not really get what "this" denotes in these lines. What is >=0 ?
I'd just remove them: I think the line above ("the number of up-stsakeing tokens needed to qualify...") explains it pretty well already.
Contributor
Author
There was a problem hiding this comment.
I clarified the comments. A lot easier this way.
src/proposal.ts
Outdated
| * | ||
| * The equation is derived from: threshold = stakesFor / (stakesAgainst + downStakeNeededToQueue) | ||
| * | ||
| * > 0 : any number of down-staking tokens greater-than-or-equal to this will qualify to move the proposal |
Contributor
There was a problem hiding this comment.
same comment as above :-)
Contributor
Author
There was a problem hiding this comment.
I clarified the comments. I think they provide more info than is readily available by thinking about the equations.
jellegerbrandy
approved these changes
Mar 22, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jellegerbrandy , can you please review the accuracy of the comments I am proposing here?