Skip to content

Conversation

@danmar
Copy link
Owner

@danmar danmar commented Nov 13, 2025

No description provided.

@danmar danmar requested a review from Copilot November 13, 2025 13:53
Copilot finished reviewing on behalf of danmar November 13, 2025 13:55
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR clarifies the documentation for the -i command-line option to better explain when and how it filters files. The key clarification is that -i only filters translation units based on their source filename before preprocessing begins, and does not apply to headers included during preprocessing.

Key Changes:

  • Updated the manual section title from "Excluding a file or folder from checking" to "Exclude files matching a given pattern"
  • Clarified that filtering happens on source filenames before preprocessing, not during preprocessing or analysis
  • Added explicit notes directing users to use --suppress for filtering warnings in headers
  • Updated command-line help text to use more precise terminology ("translation units", "source filename")

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
man/manual.md Updated section heading and expanded explanation of -i option behavior, emphasizing that filtering happens before preprocessing and only applies to source files
cli/cmdlineparser.cpp Revised help text for -i option to clarify it skips translation units based on source filename and recommends suppressions for header warnings

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

olabetskyi
olabetskyi previously approved these changes Nov 13, 2025
olabetskyi
olabetskyi previously approved these changes Nov 14, 2025
@sonarqubecloud
Copy link

@danmar danmar merged commit 08cdf36 into danmar:main Nov 14, 2025
55 checks passed
@danmar danmar deleted the fix-14266 branch November 16, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants