-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: .NET 10 Support #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe pull request updates project configuration files to add support for Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Poem
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #226 +/- ##
=======================================
Coverage 98.54% 98.54%
=======================================
Files 22 22
Lines 274 274
Branches 43 43
=======================================
Hits 270 270
Misses 1 1
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tests/NetEvolve.FluentValue.Tests.Unit/ConstraintTests.cs (1)
42-51: Consider consistency withChainedInvalidOperationsDatapattern.This data provider returns
Func<IConstraint>[]whileChainedInvalidOperationsDatanow returnsIEnumerable<Func<Func<IConstraint>>>. If the double-wrapping pattern was needed to resolve TUnit0046 warnings, verify whether this provider also needs the same treatment, or document why the patterns differ.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
📒 Files selected for processing (4)
.editorconfig(1 hunks)Directory.Build.props(1 hunks)Directory.Packages.props(1 hunks)tests/NetEvolve.FluentValue.Tests.Unit/ConstraintTests.cs(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Build & Tests / Build Solution / Build .NET solution
- GitHub Check: Agent
- GitHub Check: CodeQL analysis (csharp)
🔇 Additional comments (4)
.editorconfig (1)
44-46: LGTM! Correct addition of.slnxto XML project file formatting rules.The
.slnxformat is the new XML-based solution file format, and including it with other XML project files ensures consistent 2-space indentation.Directory.Packages.props (1)
13-13: LGTM! SonarAnalyzer.CSharp is now unconditionally included.Making the analyzer unconditional ensures consistent code analysis across all build environments (local and CI), improving code quality coverage.
Directory.Build.props (1)
12-13: Target framework extension to .NET 10 looks good.Adding
net10.0to bothNetEvolve_ProjectTargetFrameworksandNetEvolve_TestTargetFrameworksfollows the established pattern. The build pipeline uses a shared workflow that should handle the .NET 10 SDK setup, so ensure your organization's pipeline template includes the necessary .NET 10 runtime for building and testing.tests/NetEvolve.FluentValue.Tests.Unit/ConstraintTests.cs (1)
11-17: The type signature is correct per TUnit's MethodDataSource pattern requirements.The apparent type mismatch is intentional and correct. When a test parameter is
Func<IConstraint>, theMethodDataSourcemust returnIEnumerable<Func<Func<IConstraint>>>. TUnit automatically unwraps one layer ofFuncat runtime, calling the inner function to produce the value passed to the test. The removal of#pragma warning disable TUnit0046confirms this pattern satisfies TUnit's analyzer; the refactoring is sound.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.