fix(deps): resolve unsupported puppeteer message #343
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wanted to resolve issue #336 ("npm WARN deprecated [email protected]: < 19.4.0 is no longer supported") and updates the dependency puppeteer to the latest 19.x.x version, which is 19.11.1.
(puppeteer 20.0.0 is a breaking change, so this version is not used.)
Furthermore the dependency netlify-cli is updated to 14.4.0. This resolves the issue that
npm ci
would otherwise fail with the message"npm ERR! code EBADPLATFORM"
if puppeteer
18.2.1
,19.4.0
or19.11.1
is installed.jest is updated to 28.1.3, which is necessary after updating puppeteer.
Verification
Execute:
No deprecation warning such as "npm WARN deprecated [email protected]: < 19.4.0 is no longer supported" should appear (although there will be many other deprecation warnings for other dependencies). Then execute
and in a separate terminal window
npm test
The test should be successful.