Skip to content

Conversation

@Amitkahlon
Copy link
Contributor

@Amitkahlon Amitkahlon commented Dec 3, 2025

#33032

Additional details

Steps to test

How has the user experience changed?

PR Tasks


Note

Removes Bluebird and migrates async flows to native Promises/async‑await across CLI, server, fixtures, saved state, and tests.

  • Core/Server:
    • packages/server/lib/cypress.ts: replace Promise.try with Promise.resolve().then(...); retain promise-based runElectron; no behavior change intended.
  • Fixtures:
    • packages/server/lib/fixture.ts: remove Bluebird; replace Bluebird.delay with setTimeout via native Promise; keep async APIs intact.
  • Saved State:
    • packages/server/lib/saved_state.ts: convert formStatePath to async and use fs-extra.pathExists; adjust returns to Promise types; keep create() API, wrapping set with allowed-key normalization.
  • CLI:
    • cli/lib/exec/spawn.ts: replace new Bluebird(...) with new Promise(...) in spawn wrapper.
  • Tests:
    • packages/server/test/unit/modes/interactive_spec.js: update setup to await savedState.create() in beforeEach.

Written by Cursor Bugbot for commit e656950. This will update automatically on new commits. Configure here.

@CLAassistant
Copy link

CLAassistant commented Dec 3, 2025

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link
Collaborator

@Amitkahlon Amitkahlon marked this pull request as ready for review December 4, 2025 12:22
@Amitkahlon
Copy link
Contributor Author

Amitkahlon commented Dec 4, 2025

@jennifer-shehane I would like to add more changes, Could you please provide me with some feedback for what I did already?

@Amitkahlon Amitkahlon marked this pull request as draft December 4, 2025 13:20
@Amitkahlon Amitkahlon marked this pull request as ready for review December 4, 2025 15:01
@jennifer-shehane
Copy link
Member

@Amitkahlon Going to kick off tests

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexsch01
Copy link
Contributor

The spacing/indentation changes should be reverted

@jennifer-shehane
Copy link
Member

@alexsch01 Yah a bit weird that wasn't surfaced by linting. Addressed here: e656950

@jennifer-shehane jennifer-shehane merged commit 6ea73fa into cypress-io:develop Dec 9, 2025
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants