-
Notifications
You must be signed in to change notification settings - Fork 3.4k
chore: Replace Bluebird promises with native promises #33056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Replace Bluebird promises with native promises #33056
Conversation
|
|
@jennifer-shehane I would like to add more changes, Could you please provide me with some feedback for what I did already? |
…mitkahlon/cypress into refactor/remove-bluebird-utils
|
@Amitkahlon Going to kick off tests |
jennifer-shehane
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
The spacing/indentation changes should be reverted |
|
@alexsch01 Yah a bit weird that wasn't surfaced by linting. Addressed here: e656950 |
#33032
Additional details
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Removes Bluebird and migrates async flows to native Promises/async‑await across CLI, server, fixtures, saved state, and tests.
packages/server/lib/cypress.ts: replacePromise.trywithPromise.resolve().then(...); retain promise-basedrunElectron; no behavior change intended.packages/server/lib/fixture.ts: remove Bluebird; replaceBluebird.delaywithsetTimeoutvia nativePromise; keep async APIs intact.packages/server/lib/saved_state.ts: convertformStatePathtoasyncand usefs-extra.pathExists; adjust returns toPromisetypes; keepcreate()API, wrappingsetwith allowed-key normalization.cli/lib/exec/spawn.ts: replacenew Bluebird(...)withnew Promise(...)in spawn wrapper.packages/server/test/unit/modes/interactive_spec.js: update setup toawait savedState.create()inbeforeEach.Written by Cursor Bugbot for commit e656950. This will update automatically on new commits. Configure here.