Do not exit with 0 when running with NODE_OPTIONS

[bahmutov]

bug

When using NODE_OPTIONS=--max_old_space_size=4096 Cypress run through CLI silently fails but the exit code is 0.

• why is this option affecting the run?
• why don't we exit with 1?
• why don't we print the problem?

$ NODE_OPTIONS=--max_old_space_size=4096 DEBUG=cypress:* npm run cypress:open

> cypress-test-tiny@1.0.0 cypress:open /Users/gleb/git/cypress-test-tiny
> cypress open

  cypress:cli cli starts with arguments ["/Users/gleb/.nvm/versions/node/v8.9.4/bin/node","/Users/gleb/git/cypress-test-tiny/node_modules/.bin/cypress","open"] +0ms
  cypress:cli program parsing arguments +3ms
  cypress:cli opening Cypress +1ms
  cypress:cli parsed cli options {} +129ms
  cypress:cli opening from options {"project":"/Users/gleb/git/cypress-test-tiny"} +0ms
  cypress:cli command line arguments ["--project","/Users/gleb/git/cypress-test-tiny"] +1ms
  cypress:cli verifying Cypress app +0ms
  cypress:cli path to info.json file /Users/gleb/git/cypress-test-tiny/node_modules/cypress/dist/info.json +0ms
  cypress:cli { version: '2.1.0', verifiedVersion: '2.1.0' } +16ms
  cypress:cli installed version is 2.1.0 comparing to 2.1.0 +17ms
  cypress:cli checking if executable exists /Users/gleb/git/cypress-test-tiny/node_modules/cypress/dist/Cypress.app/Contents/MacOS/Cypress +0ms
  cypress:cli path to info.json file /Users/gleb/git/cypress-test-tiny/node_modules/cypress/dist/info.json +2ms
  cypress:cli has verified version 2.1.0 +2ms
  cypress:cli run verification check? false +0ms
  cypress:cli needs XVFB? false +0ms
  cypress:cli spawning Cypress /Users/gleb/git/cypress-test-tiny/node_modules/cypress/dist/Cypress.app/Contents/MacOS/Cypress +0ms
  cypress:cli spawn args ["--project","/Users/gleb/git/cypress-test-tiny","--cwd","/Users/gleb/git/cypress-test-tiny"] { dev: undefined, detached: false, stdio: 'inherit' } +0ms
~/git/cypress-test-tiny on master
$ echo $?
0

[bahmutov]

Related to #1675 and #1434

[bahmutov]

The option itself is undocumented v8 flag

• Can we document --max_old_space_size or is it deprecated? nodejs/node#7937
• https://github.com/thlorenz/v8-flags/blob/master/flags-0.11.md#max_old_space_size-0-integer

node --v8-options | grep max_old
  --max_old_space_size (max size of the old space (in Mbytes))

[bahmutov]

Some experiments

$ NODE_OPTIONS=--max_old_space_size=4096 node -e 'console.log("hi")'
hi
$ NODE_OPTIONS=--max_old_space_size=9009900 node -e 'console.log("hi")'
hi
$ NODE_OPTIONS=--max_old_space_size=0 node -e 'console.log("hi")'
hi
$ NODE_OPTIONS=--max_old_space_size=1 node -e 'console.log("hi")'
Segmentation fault: 11
$ echo $?
139
$ NODE_OPTIONS= ./node_modules/cypress/dist/Cypress.app/Contents/MacOS/Cypress
Segmentation fault: 11
$ echo $?
139
$ NODE_OPTIONS=--max_old_space_size=4096 ./node_modules/cypress/dist/Cypress.app/Contents/MacOS/Cypress
Segmentation fault: 11

[bahmutov]

Electron v1.8.3, v2.0.0 crashes when NODE_OPTIONS is set electron/electron#12695

[nothingismagick]

Just a hunch - are you running the latest node 8.11.2? There were a great number of improvements in the crypto stack related to cache bloat issues.

[jennifer-shehane]

We are on node 8.2.1 - https://github.com/cypress-io/cypress/blob/develop/.node-version#L2

[bahmutov]

I think this is an interesting bug that surfaces a missing error handling - when we attempt to start the binary, but fail but CLI still thinks everything is great

[beaugunderson]

On High Sierra cypress segfaults for me if NODE_OPTIONS=--max_old_space_size=4096 or if NODE_OPTIONS="".

I have to unset NODE_OPTIONS for cypress not to segfault.

Versions:

Cypress 3.1.0
macOS 10.13.6
node 10.8.0