Skip to content

Conversation

@MikeMcC399
Copy link
Collaborator

Situation

This repo contains no examples of using Cypress Docker images with the Cypress JavaScript GitHub Action cypress-io/github-action.

The included/README links to https://github.com/cypress-io/github-action#docker-image where there is only an example with cypress/browsers:latest. Examples for cypress/base and cypress/included are missing.

Change

  1. Add a workflow example-cypress-github-action.yml to run against the examples, showing each of the browsers: Electron, Chrome, Edge and Firefox. The workflow is triggered only on manual demand with workflow_dispatch.
  2. Add a link into README > Examples

@cypress-app-bot
Copy link

@MikeMcC399

This comment was marked as outdated.

@MikeMcC399 MikeMcC399 marked this pull request as ready for review June 19, 2024 05:19
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks.

@jennifer-shehane jennifer-shehane merged commit f4a78b6 into cypress-io:master Jun 19, 2024
@MikeMcC399 MikeMcC399 deleted the add-gha-examples branch June 19, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants