Skip to content

Conversation

@MikeMcC399
Copy link
Collaborator

Issues

The factory/README file contains examples that do not run and are incomplete.

  1. The specified Chrome and Edge browser versions are no longer available for download and all build examples fail.
  2. If the build commands are re-run they fail to install the Cypress binary due to Docker caching. Attempting to run Cypress then fails due to missing Cypress binary.
  3. The run examples rely on a Cypress project which is not defined.

Changes

Versions

Example versions are updated to latest.

Component New version
NODE_VERSION 20.14.0
YARN_VERSION 1.22.22
CYPRESS_VERSION 13.11.0
CHROME_VERSION 125.0.6422.141-1
FIREFOX_VERSION 126.0.1
EDGE_VERSION 125.0.2535.85-1

Cypress binary

npx cypress install is added, together with an explanation to ensure that the Cypress binary is also installed into the image.

Cypress project

A description of how to create a simple example Cypress E2E project is added.

Other changes

Docker compose

  • removed obsolete version

Run examples

  • made interactive (-it option)
  • instruct to remove container after use (--rm option)

@cypress-app-bot
Copy link

@MikeMcC399

This comment was marked as outdated.

@MikeMcC399 MikeMcC399 self-assigned this Jun 8, 2024
@MikeMcC399 MikeMcC399 marked this pull request as ready for review June 9, 2024 18:55
@MikeMcC399 MikeMcC399 force-pushed the factory-readme-examples branch 3 times, most recently from 585b5e3 to 59a8dbd Compare June 10, 2024 14:25
@MikeMcC399 MikeMcC399 force-pushed the factory-readme-examples branch from 59a8dbd to 0feed77 Compare June 10, 2024 14:34
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating!

@jennifer-shehane jennifer-shehane merged commit 86b5e12 into cypress-io:master Jun 10, 2024
@MikeMcC399
Copy link
Collaborator Author

@jennifer-shehane

Thanks for updating!

Thanks for merging! 🙂
There is more to come and I'm trying to keep the PR contents in manageable chunks for review.

@MikeMcC399 MikeMcC399 deleted the factory-readme-examples branch June 10, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants