feat: add nativeException function #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwmkerr
force-pushed
the
feat/add-native-exception-function
branch
from
8434f11 to
952b251
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to be able to test native exceptions in certain scenarios, but the
nativeCrashfunction callsfatalErrorfor iOS, which is a non-recoverable crash.This is by design I assume, and Android has nothing exactly equivalent. To support more testing scenarios this adds
nativeExceptionthat throws an exception in android, and throwsNSExceptionfor iOS, allowing native exception handlers to be tested.This does cause some confusion - the behaviour of
nativeCrashandnativeExceptionis the same for Android and different for iOS, although that could be argued as a valid difference in the platform, but I'm open to any suggestions to improve this!I've also updated the docs to be explicit about what each implementation does.