Skip to content

Conversation

@sydneycollins-cio
Copy link

@sydneycollins-cio sydneycollins-cio commented Feb 19, 2025

This PR updates @segment/tsub to ^2.0.0 to resolve compatibility issues. These changes ensure that the dependencies align with a stable and supported version, preventing installation conflicts.
Also added test to prevent use from integrating a new version that will not download

https://www.loom.com/share/e203c793ac5a4572915a0227c89df6ba

Newer versions of node were experiencing

npm error code 1
npm error path /Users/sydneycollins/Documents/cdp-node/node_modules/@stdlib/number-float64-base-normalize
npm error command failed
npm error command sh -c node-gyp rebuild
npm error gyp info it worked if it ends with ok
npm error gyp info using [email protected]
npm error gyp info using [email protected] | darwin | arm64
npm error gyp info find Python using Python version 3.10.16 found at "/opt/homebrew/opt/[email protected]/bin/python3.10"
npm error gyp info spawn /opt/homebrew/opt/[email protected]/bin/python3.10
npm error gyp info spawn args [
npm error gyp info spawn args '/Users/sydneycollins/.nvm/versions/node/v20.18.0/lib/node_modules/npm/node_modules/node-gyp/gyp/gyp_main.py',
npm error gyp info spawn args 'binding.gyp',
npm error gyp info spawn args '-f',
npm error gyp info spawn args 'make',
npm error gyp info spawn args '-I',
npm error gyp info spawn args '/Users/sydneycollins/Documents/cdp-node/node_modules/@stdlib/number-float64-base-normalize/build/config.gypi',
npm error gyp info spawn args '-I',
npm error gyp info spawn args '/Users/sydneycollins/.nvm/versions/node/v20.18.0/lib/node_modules/npm/node_modules/node-gyp/addon.gypi',
npm error gyp info spawn args '-I',
npm error gyp info spawn args '/Users/sydneycollins/Library/Caches/node-gyp/20.18.0/include/node/common.gypi',
npm error gyp info spawn args '-Dlibrary=shared_library',
npm error gyp info spawn args '-Dvisibility=default',
npm error gyp info spawn args '-Dnode_root_dir=/Users/sydneycollins/Library/Caches/node-gyp/20.18.0',
npm error gyp info spawn args '-Dnode_gyp_dir=/Users/sydneycollins/.nvm/versions/node/v20.18.0/lib/node_modules/npm/node_modules/node-gyp',
npm error gyp info spawn args '-Dnode_lib_file=/Users/sydneycollins/Library/Caches/node-gyp/20.18.0/<(target_arch)/node.lib',
npm error gyp info spawn args '-Dmodule_root_dir=/Users/sydneycollins/Documents/cdp-node/node_modules/@stdlib/number-float64-base-normalize',
npm error gyp info spawn args '-Dnode_engine=v8',
npm error gyp info spawn args '--depth=.',
npm error gyp info spawn args '--no-parallel',
npm error gyp info spawn args '--generator-output',
npm error gyp info spawn args 'build',
npm error gyp info spawn args '-Goutput_dir=.'
npm error gyp info spawn args ]
npm error gyp: binding.gyp not found (cwd: /Users/sydneycollins/Documents/cdp-node/node_modules/@stdlib/number-float64-base-normalize) while trying to load binding.gyp
npm error gyp ERR! configure error 
npm error gyp ERR! stack Error: `gyp` failed with exit code: 1
npm error gyp ERR! stack at ChildProcess.<anonymous> (/Users/sydneycollins/.nvm/versions/node/v20.18.0/lib/node_modules/npm/node_modules/node-gyp/lib/configure.js:297:18)
npm error gyp ERR! stack at ChildProcess.emit (node:events:519:28)
npm error gyp ERR! stack at ChildProcess._handle.onexit (node:internal/child_process:294:12)
npm error gyp ERR! System Darwin 24.0.0
npm error gyp ERR! command "/Users/sydneycollins/.nvm/versions/node/v20.18.0/bin/node" "/Users/sydneycollins/.nvm/versions/node/v20.18.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
npm error gyp ERR! cwd /Users/sydneycollins/Documents/cdp-node/node_modules/@stdlib/number-float64-base-normalize
npm error gyp ERR! node -v v20.18.0
npm error gyp ERR! node-gyp -v v10.1.0
npm error gyp ERR! not ok
npm error A complete log of this run can be found in: /Users/sydneycollins/.npm/_logs/2025-02-19T19_51_19_623Z-debug-0.log
sydneycollins@Sydney-Wisdom-Collins cdp-node % npm install /Users/sydneycollins/code/cdp-analytics-js/packages/browser/customerio-cdp-analytics-browser-0.2.3.tgz

@sydneycollins-cio sydneycollins-cio force-pushed the cdp-2798-fix-library-install branch from b3b2043 to 219455f Compare February 19, 2025 20:10
@sydneycollins-cio sydneycollins-cio changed the title Cdp 2798 fix library install [CDP-2798] Fixed installation js snippet for later versions of node Feb 19, 2025
@sydneycollins-cio sydneycollins-cio self-assigned this Feb 19, 2025
@guglielmi-s
Copy link

guglielmi-s commented Feb 24, 2025

thanks, at the moment i can't install the package via npm
i m gonna share my current error log
npm install @customerio/cdp-analytics-browser npm warn EBADENGINE Unsupported engine { npm warn EBADENGINE package: undefined, npm warn EBADENGINE required: { node: '20.15.0' }, npm warn EBADENGINE current: { node: 'v18.20.4', npm: '10.7.0' } npm warn EBADENGINE } npm error code 1 npm error path /Users/guglielmi/docsity-docker/apps/frontend-web/node_modules/@stdlib/number-float64-base-normalize npm error command failed npm error command sh -c node-gyp rebuild npm error gyp info it worked if it ends with ok npm error gyp info using [email protected] npm error gyp info using [email protected] | darwin | arm64 npm error gyp info find Python using Python version 3.13.0 found at "/opt/homebrew/opt/[email protected]/bin/python3.13" npm error gyp info spawn /opt/homebrew/opt/[email protected]/bin/python3.13 npm error gyp info spawn args [ npm error gyp info spawn args '/Users/guglielmi/docsity-docker/apps/frontend-web/node_modules/node-gyp/gyp/gyp_main.py', npm error gyp info spawn args 'binding.gyp', npm error gyp info spawn args '-f', npm error gyp info spawn args 'make', npm error gyp info spawn args '-I', npm error gyp info spawn args '/Users/guglielmi/docsity-docker/apps/frontend-web/node_modules/@stdlib/number-float64-base-normalize/build/config.gypi', npm error gyp info spawn args '-I', npm error gyp info spawn args '/Users/guglielmi/docsity-docker/apps/frontend-web/node_modules/node-gyp/addon.gypi', npm error gyp info spawn args '-I', npm error gyp info spawn args '/Users/guglielmi/Library/Caches/node-gyp/18.20.4/include/node/common.gypi', npm error gyp info spawn args '-Dlibrary=shared_library', npm error gyp info spawn args '-Dvisibility=default', npm error gyp info spawn args '-Dnode_root_dir=/Users/guglielmi/Library/Caches/node-gyp/18.20.4', npm error gyp info spawn args '-Dnode_gyp_dir=/Users/guglielmi/docsity-docker/apps/frontend-web/node_modules/node-gyp', npm error gyp info spawn args '-Dnode_lib_file=/Users/guglielmi/Library/Caches/node-gyp/18.20.4/<(target_arch)/node.lib', npm error gyp info spawn args '-Dmodule_root_dir=/Users/guglielmi/docsity-docker/apps/frontend-web/node_modules/@stdlib/number-float64-base-normalize', npm error gyp info spawn args '-Dnode_engine=v8', npm error gyp info spawn args '--depth=.', npm error gyp info spawn args '--no-parallel', npm error gyp info spawn args '--generator-output', npm error gyp info spawn args 'build', npm error gyp info spawn args '-Goutput_dir=.' npm error gyp info spawn args ] npm error gyp: binding.gyp not found (cwd: /Users/guglielmi/docsity-docker/apps/frontend-web/node_modules/@stdlib/number-float64-base-normalize) while trying to load binding.gyp npm error gyp ERR! configure error npm error gyp ERR! stack Error: gyp failed with exit code: 1 npm error gyp ERR! stack at ChildProcess.onCpExit (/Users/guglielmi/docsity-docker/apps/frontend-web/node_modules/node-gyp/lib/configure.js:325:16) npm error gyp ERR! stack at ChildProcess.emit (node:events:517:28) npm error gyp ERR! stack at ChildProcess._handle.onexit (node:internal/child_process:292:12) npm error gyp ERR! System Darwin 23.5.0

the pr will fix also this issue? @sydneycollins-cio

@sydneycollins-cio
Copy link
Author

@guglielmi-s Thanks for commenting! Yes this should fix that issue, if you are can change your node version to 17 in the meantime it should work.

@sydneycollins-cio sydneycollins-cio merged commit a391cdc into main Mar 3, 2025
5 checks passed
@sydneycollins-cio sydneycollins-cio deleted the cdp-2798-fix-library-install branch March 3, 2025 17:58
@sydneycollins-cio
Copy link
Author

@guglielmi-s Thanks for commenting! Yes this should fix that issue, if you are can change your node version to 17 in the meantime it should work.

This issue is resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants