Skip to content
This repository was archived by the owner on Jan 18, 2021. It is now read-only.

Add custom url in config, refactoring and code optimization #12

Merged
merged 12 commits into from
Aug 12, 2018
Merged

Add custom url in config, refactoring and code optimization #12

merged 12 commits into from
Aug 12, 2018

Conversation

@rhoriguchi
Copy link
Contributor

@rhoriguchi rhoriguchi commented Aug 10, 2018

No description provided.

@rhoriguchi rhoriguchi requested a review from ludeeus as a code owner August 10, 2018 23:24
@rhoriguchi rhoriguchi changed the title Refactoring Refactoring and code optimization Aug 11, 2018
@ludeeus
Copy link
Contributor

ludeeus commented Aug 11, 2018

@rhoriguchi thanks for this :)
Since it changes so much I need to test it out locally before I can do a proper review of it, I see the last commit was 27min ago, can you ping me when you are done and I can test it out?

tip: use WIP in the title when you expect to push more commits after creating a PR :)

@ludeeus ludeeus self-assigned this Aug 11, 2018
@rhoriguchi rhoriguchi changed the title Refactoring and code optimization WIP Refactoring and code optimization Aug 11, 2018
@rhoriguchi rhoriguchi changed the title WIP Refactoring and code optimization Add custom url in config, refactoring and code optimization Aug 12, 2018
@rhoriguchi rhoriguchi mentioned this pull request Aug 12, 2018
Merged
@ghost ghost added the in progress label Aug 12, 2018
ludeeus
ludeeus approved these changes Aug 12, 2018
View reviewed changes
Copy link
Contributor

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWESOME!!! 🎉

@ludeeus
Copy link
Contributor

ludeeus commented Aug 12, 2018

Thank you for this awesome addition @rhoriguchi 🥇

@ludeeus ludeeus merged commit bc65c3f into custom-components:master Aug 12, 2018
@ghost ghost removed the in progress label Aug 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@ludeeus ludeeus ludeeus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ludeeus ludeeus

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rhoriguchi @ludeeus