Skip to content

Fail empty scope tests with empty fixtures #2908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025
Merged

Fail empty scope tests with empty fixtures #2908

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions packages/cursorless-vscode-e2e/src/suite/scopes.vscode.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ async function runTest(file: string, languageId: string, facetId: string) {

const editor = ide.activeTextEditor!;

const outputFixture = ((): string => {
const [outputFixture, numScopes] = ((): [string, number] => {
const config = {
visibleOnly: false,
scopeType,
Expand All @@ -137,17 +137,21 @@ async function runTest(file: string, languageId: string, facetId: string) {
includeNestedTargets: false,
},
);
return serializeIterationScopeFixture(code, iterationScopes);
return [
serializeIterationScopeFixture(code, iterationScopes),
iterationScopes.length,
];
}

const scopes = scopeProvider.provideScopeRanges(editor, config);

return serializeScopeFixture(facetId, code, scopes);
return [serializeScopeFixture(facetId, code, scopes), scopes.length];
})();

if (shouldUpdateFixtures()) {
await fsp.writeFile(file, outputFixture);
} else {
assert.isAbove(numScopes, 0, "No scopes found");
assert.equal(outputFixture, fixture);
}
}
Expand Down
Loading