Skip to content

Make "take" preserve semantics of the target that is selected #2184

@pokey

Description

@pokey

Instead of having a "from" that sets a special implicit target (see #2155), we would like to use "take". The problem is that you lose the rich semantics of the target. Eg "take arg chuck this" won't clean up the comma

The solution

  • the "take" action will also set a special target at the same position that it sets the cursor
  • we highlight the target, so that the cursor highlight color will change
  • next time they issue a command that uses "this" or implicit mark, it will use the stored target instead of just raw selection
  • if selection changes before selection is used, we drop the target
  • as extra credit, we keep a list of past targets so that if they "curse undo", we can restore the old stored target

See #2155 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions