SI-8933 Disable static Symbol literal cache in traits

In Scala 2.8.2, an optimization was added to create a static
cache for Symbol literals (ie, the results of `Symbol.apply("foo"))`.
This saves the map lookup on the second pass through code.

This actually was broken somewhere during the Scala 2.10 series,
after the addition of an overloaded `apply` method to `Symbol`.

The cache synthesis code was made aware of the overload and brought
back to working condition recently, in scala#3149.

However, this has uncovered a latent bug when the Symbol literals are
defined with traits.

One of the enclosed tests failed with:

	  jvm > t8933b-run.log
	java.lang.IllegalAccessError: tried to access field MotherClass.symbol$1 from class MixinWithSymbol$class
	        at MixinWithSymbol$class.symbolFromTrait(A.scala:3)
	        at MotherClass.symbolFromTrait(Test.scala:1)

This commit simply disables the optimization if we are in a trait.
Alternative fixes might be: a) make the static Symbol cache field
public / b) "mixin" the static symbol cache. Neither of these
seem worth the effort and risk for an already fairly situational
optimization.

Here's how the optimization looks in a class:

	% cat sandbox/test.scala; qscalac sandbox/test.scala && echo ":javap C" | qscala;
	class C {
	  'a; 'b
	}
	Welcome to Scala version 2.11.5-20141106-145558-aa558dce6d (Java HotSpot(TM) 64-Bit Server VM, Java 1.8.0_20).
	Type in expressions to have them evaluated.
	Type :help for more information.

	scala> :javap C
	  Size 722 bytes
	  MD5 checksum 6bb00189166917254e8d40499ee7c887
	  Compiled from "test.scala"
	public class C

	{
	  public static {};
	    descriptor: ()V
	    flags: ACC_PUBLIC, ACC_STATIC
	    Code:
	      stack=2, locals=0, args_size=0
	         0: getstatic     adriaanm#16                 // Field scala/Symbol$.MODULE$:Lscala/Symbol$;
	         3: ldc           adriaanm#18                 // String a
	         5: invokevirtual adriaanm#22                 // Method scala/Symbol$.apply:(Ljava/lang/String;)Lscala/Symbol;
	         8: putstatic     adriaanm#26                 // Field symbol$1:Lscala/Symbol;
	        11: getstatic     adriaanm#16                 // Field scala/Symbol$.MODULE$:Lscala/Symbol$;
	        14: ldc           scala#28                 // String b
	        16: invokevirtual adriaanm#22                 // Method scala/Symbol$.apply:(Ljava/lang/String;)Lscala/Symbol;
	        19: putstatic     scala#31                 // Field symbol$2:Lscala/Symbol;
	        22: return

	  public C();
	    descriptor: ()V
	    flags: ACC_PUBLIC
	    Code:
	      stack=1, locals=1, args_size=1
	         0: aload_0
	         1: invokespecial scala#34                 // Method java/lang/Object."<init>":()V
	         4: getstatic     adriaanm#26                 // Field symbol$1:Lscala/Symbol;
	         7: pop
	         8: getstatic     scala#31                 // Field symbol$2:Lscala/Symbol;
	        11: pop
	        12: return
	}

fixup

Author: retronym

src/compiler/scala/tools/nsc/transform/CleanUp.scala

@@ -520,7 +520,7 @@ abstract class CleanUp extends Statics with Transform with ast.TreeDSL {
       * And, finally, be advised - Scala's Symbol literal (scala.Symbol) and the Symbol class of the compiler
       * have little in common.
       */
-      case Apply(fn, (arg @ Literal(Constant(symname: String))) :: Nil) if fn.symbol == Symbol_apply =>
+      case Apply(fn, (arg @ Literal(Constant(symname: String))) :: Nil) if fn.symbol == Symbol_apply && !currentClass.isTrait =>
         def transformApply = {
           // add the symbol name to a map if it's not there already
           val rhs = gen.mkMethodCall(Symbol_apply, arg :: Nil)

test/files/run/t8933.check

@@ -0,0 +1 @@
+'traitSymbol

test/files/run/t8933/A_1.scala

@@ -0,0 +1,6 @@
+class MotherClass
+
+trait MixinWithSymbol {
+  self: MotherClass =>
+  def symbolFromTrait: Symbol = 'traitSymbol
+}

test/files/run/t8933/Test_2.scala

@@ -0,0 +1,10 @@
+class MotherClass extends MixinWithSymbol {
+  val classSymbol = 'classSymbol
+}
+
+object Test {
+  def main(args: Array[String]) {
+    val symbol = (new MotherClass).symbolFromTrait
+    println(symbol)
+  }
+}

test/files/run/t8933b/A.scala

@@ -0,0 +1,4 @@
+trait MixinWithSymbol {
+  self: MotherClass =>
+  def symbolFromTrait: Any = 'traitSymbol
+}

test/files/run/t8933b/Test.scala

@@ -0,0 +1,9 @@
+class MotherClass extends MixinWithSymbol {
+  def foo = 'sym1
+}
+
+object Test {
+  def main(args: Array[String]) {
+    (new MotherClass).symbolFromTrait
+  }
+}