Skip to content

Deprecate lineage derived methods #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 10, 2025
Merged

Deprecate lineage derived methods #84

merged 10 commits into from
Sep 10, 2025

Conversation

@mpkorstanje
Copy link
Contributor

@mpkorstanje mpkorstanje commented Jul 9, 2025 •
edited
Loading

⚡️ What's your motivation?

In #76 Lineage became part of the public API. This removes the need for various queries that depend on the lineage or the lineage reducer.

To ensure test coverage remains the NamingStrategyAcceptanceTest was added.

Fixes: #82.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@mpkorstanje
Deprecate lineage derived methods
2295b50 
In #76 Lineage became part of the public API. This removes the need for
various queries that depend on the lineage or the lineage reducer.

To ensure test coverage remains the `NamingStrategyAcceptanceTest` was
added.

Fixes: #82.
@mpkorstanje mpkorstanje mentioned this pull request Jul 9, 2025
Open
7 tasks
@mpkorstanje mpkorstanje requested a review from davidjgoss July 15, 2025 15:43
@davidjgoss davidjgoss mentioned this pull request Jul 15, 2025
Merged
7 tasks
clrudolphi added a commit to clrudolphi/query that referenced this pull request Jul 18, 2025
@clrudolphi
Modified to conform to changes coming in Query cucumber#84 (Deprecate…
828599e 
… lineage derived methods).
mpkorstanje added a commit to cucumber/junit-xml-formatter that referenced this pull request Sep 5, 2025
@davidjgoss @mpkorstanje
Lineage rework (#77)
70a9879 
Pre-emptively migrate away from soon-to-be-deprecated methods
(cucumber/query#84), partly to validate the consumer cost is not too
great.

Also while we're here, get rid of node:assert usage and replace with a
simple function, thus removing unnecessary coupling to Node.js as a
runtime.

Co-authored-by: M.P. Korstanje <[email protected]>
@mpkorstanje mpkorstanje marked this pull request as ready for review September 10, 2025 22:02
@mpkorstanje mpkorstanje merged commit 82b3190 into main Sep 10, 2025
9 checks passed
@mpkorstanje mpkorstanje deleted the deprecate-lineage-derrived-queries branch September 10, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidjgoss davidjgoss Awaiting requested review from davidjgoss

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clean up Lineage dependent methods from Query

2 participants

@mpkorstanje