Skip to content

Conversation

RolandArgos
Copy link
Contributor

@RolandArgos RolandArgos commented Oct 31, 2017

This is a second attempt at a more simple fix for the duration in the cucumber.json to be in ticks thus bringing it in line with cucumber reporting in other platforms

@charlierudolph I did a PR back in september but only just found the time to revisit and do it again as per your previous comments keeping the internals in MS and only converting for the JSON formatter

@charlierudolph charlierudolph changed the title Second attempt to fix bug in json formatter duration revert json formatter duration to nanoseconds Jan 24, 2018
@charlierudolph charlierudolph merged commit 99fe37f into cucumber:master Jan 24, 2018
@aslakhellesoy
Copy link
Contributor

Hi @RolandArgos,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@lock
Copy link

lock bot commented Jan 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants