Skip to content

Update ViewService.py #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update ViewService.py #1271

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c6cee86
Update ViewService.py
bdunleavy22 Aug 27, 2025
75f0493
Update ViewService.py
bdunleavy22 Aug 27, 2025
eab6014
Update ViewService_test.py
bdunleavy22 Sep 3, 2025
ebf096f
Update ViewService.py
bdunleavy22 Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions TM1py/Services/ViewService.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def get(self, cube_name: str, view_name: str, private: bool = False, **kwargs) -
else:
return self.get_native_view(cube_name=cube_name, view_name=view_name, private=private)

def get_native_view(self, cube_name: str, view_name: str, private=False, **kwargs) -> NativeView:
def get_native_view(self, cube_name: str, view_name: str, private=False, get_element_names: bool = True, **kwargs) -> NativeView:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rename to skip_element_names with default False.

In most other tm1py functions, we use the skip terminology for optional behaviour changes.

""" Get a NativeView from TM1 Server

:param cube_name: string, name of the cube
Expand All @@ -81,19 +81,20 @@ def get_native_view(self, cube_name: str, view_name: str, private=False, **kwarg
:return: instance of TM1py.NativeView
"""
view_type = "PrivateViews" if private else "Views"
expand_elements = ',Elements($select=Name)' if get_element_names else ''
url = format_url(
"/Cubes('{}')/{}('{}')?$expand="
"tm1.NativeView/Rows/Subset($expand=Hierarchy($select=Name;"
"$expand=Dimension($select=Name)),Elements($select=Name);"
"$expand=Dimension($select=Name)){};"
"$select=Expression,UniqueName,Name, Alias), "
"tm1.NativeView/Columns/Subset($expand=Hierarchy($select=Name;"
"$expand=Dimension($select=Name)),Elements($select=Name);"
"$expand=Dimension($select=Name)){};"
"$select=Expression,UniqueName,Name,Alias), "
"tm1.NativeView/Titles/Subset($expand=Hierarchy($select=Name;"
"$expand=Dimension($select=Name)),Elements($select=Name);"
"$expand=Dimension($select=Name)){};"
"$select=Expression,UniqueName,Name,Alias), "
"tm1.NativeView/Titles/Selected($select=Name)",
cube_name, view_type, view_name)
cube_name, view_type, view_name, expand_elements, expand_elements, expand_elements)
response = self._rest.GET(url, **kwargs)
native_view = NativeView.from_json(response.text, cube_name)
return native_view
Expand Down