-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(native): Use async logger for Node.js non blocking STDOUT #10146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9c23c68 to
537c8f2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10146 +/- ##
=======================================
Coverage 77.98% 77.98%
=======================================
Files 457 457
Lines 91092 91092
Branches 3337 3337
=======================================
+ Hits 71037 71041 +4
+ Misses 19577 19573 -4
Partials 478 478
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KSDaemon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
| simple_logger = "1.7.0" | ||
| tokio = { version = "1", features = ["full", "rt"] } | ||
| uuid = { version = "1", features = ["v4"] } | ||
| log_nonblock = { version = "0.1.4", optional = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Node.js marks
STDOUTandSTDERRas non blocking, it leads to a problem in Rust code, because Rust doesn't handle errors (blocking error) correctly and panics. Whenver, we try to log large payload from rust code, it crashes.New logger from
log_nonblockcrates, handle it correctly.