Skip to content

Conversation

@ovr
Copy link
Member

@ovr ovr commented Nov 17, 2025

Node.js marks STDOUT and STDERR as non blocking, it leads to a problem in Rust code, because Rust doesn't handle errors (blocking error) correctly and panics. Whenver, we try to log large payload from rust code, it crashes.

New logger from log_nonblock crates, handle it correctly.

@ovr ovr requested a review from a team as a code owner November 17, 2025 17:15
@github-actions github-actions bot added the rust Pull requests that update Rust code label Nov 17, 2025
@ovr ovr force-pushed the feat/enable-async-log branch from 9c23c68 to 537c8f2 Compare November 17, 2025 17:17
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.98%. Comparing base (bdb4c20) to head (5f0c1b0).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10146   +/-   ##
=======================================
  Coverage   77.98%   77.98%           
=======================================
  Files         457      457           
  Lines       91092    91092           
  Branches     3337     3337           
=======================================
+ Hits        71037    71041    +4     
+ Misses      19577    19573    -4     
  Partials      478      478           
Flag Coverage Δ
cube-backend 54.72% <ø> (ø)
cubesql 83.29% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

simple_logger = "1.7.0"
tokio = { version = "1", features = ["full", "rt"] }
uuid = { version = "1", features = ["v4"] }
log_nonblock = { version = "0.1.4", optional = true }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ovr ovr merged commit 149fc79 into master Nov 18, 2025
84 of 86 checks passed
@ovr ovr deleted the feat/enable-async-log branch November 18, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants