Skip to content

fix: physical binary expr compare array with 1 element fix #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: cubesql-3-04-2022
Choose a base branch
from
Open

fix: physical binary expr compare array with 1 element fix #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions datafusion/physical-expr/src/expressions/binary.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1251,6 +1251,21 @@ impl PhysicalExpr for BinaryExpr {
// if right is literal and left is array - reverse operator and parameters
self.evaluate_scalar_array(scalar, array)?
}
(ColumnarValue::Array(first_arr), ColumnarValue::Array(second_arr))
if first_arr.len() != second_arr.len() =>
{
if first_arr.len() == 1 {
match ScalarValue::try_from_array(first_arr, 0) {
Ok(scalar) => self.evaluate_scalar_array(&scalar, second_arr)?,
_ => None,
}
} else {
match ScalarValue::try_from_array(second_arr, 0) {
Ok(scalar) => self.evaluate_array_scalar(first_arr, &scalar)?,
_ => None,
}
}
}
(_, _) => None, // default to array implementation
};

Expand Down