Forward command-line flags for build scripts #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeikabu
added a commit
to jeikabu/rust-esp-container
that referenced
this pull request
Apr 19, 2020
- Before source'ing $IDF_PATH/export.sh, check if IDF_TOOLS_EXPORT_CMD is unset. This means it hasn't been source'd yet. - image-project assumes a particular target, config, and binary name. If image.sh exists, assume that is a more appropriate replacement and run it instead. - quick-build allows for quicker build iteration with less "safety" - --release is no longer required, forward command-line flags like in PR ctron#12 since it works just as well for --features as --release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should be quite straight-forward, and it lets users run builds where they need to pass in cargo flags like
--featuresetc.