Skip to content

added addLocalFolderAsync2 #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
5saviahv merged 5 commits into from
Jun 9, 2024
Merged

added addLocalFolderAsync2 #501

5saviahv merged 5 commits into from
Jun 9, 2024

Conversation

@5saviahv
Copy link
Collaborator

@5saviahv 5saviahv commented Jun 9, 2024

added addLocalFolderAsync2

  • it uses node.js callback style
  • callback is last argument like most node.js functions do
  • idea is later replace addLocalFolderAsync witrh this
  • is internally more async than former
  • default disabled "namefix" what is always enabled in addLocalFolderAsync and wont let use names with not latin1 names

updated addLocalFolder

  • uses internally addLocalFile
  • is more consistent this way

added tests for updated functions & stream lined with other tests

@5saviahv 5saviahv merged commit a8ddc64 into cthackers:master Jun 9, 2024
@captainyarr captainyarr mentioned this pull request Aug 25, 2024
Open
@harrykimpel harrykimpel mentioned this pull request Aug 27, 2024
Open
@jonny-irving jonny-irving mentioned this pull request Aug 27, 2024
Open
@snyk-matt snyk-matt mentioned this pull request Aug 27, 2024
Open
@abdulrahman305 abdulrahman305 mentioned this pull request Aug 27, 2024
Merged
@erichusband erichusband mentioned this pull request Aug 27, 2024
Open
@WeiLunSnyk WeiLunSnyk mentioned this pull request Aug 27, 2024
Open
@DevangPatelUK DevangPatelUK mentioned this pull request Aug 27, 2024
Open
@BibhutiCh BibhutiCh mentioned this pull request Aug 28, 2024
Open
@cybersec111 cybersec111 mentioned this pull request Aug 29, 2024
Open
@NOUIY NOUIY mentioned this pull request Aug 29, 2024
Open
@cdobru cdobru mentioned this pull request Aug 30, 2024
Closed
@NickyMartinez NickyMartinez mentioned this pull request Aug 30, 2024
Open
@ArunimaSuraj ArunimaSuraj mentioned this pull request Aug 31, 2024
Open
@zigwork zigwork mentioned this pull request Sep 6, 2024
Open
@davidsandilands davidsandilands mentioned this pull request Sep 8, 2024
Open
@masakiishida1022 masakiishida1022 mentioned this pull request Sep 9, 2024
Open
@guipmoraes guipmoraes mentioned this pull request Sep 10, 2024
Open
@esecdj esecdj mentioned this pull request Sep 11, 2024
Closed
This was referenced Sep 13, 2024
Open
Open
Open
Open
@Sladey01 Sladey01 mentioned this pull request Sep 18, 2024
Open
@Deloitte-ngerard Deloitte-ngerard mentioned this pull request Nov 1, 2024
Open
@0xdekster 0xdekster mentioned this pull request Nov 1, 2024
Open
@VasuAz400 VasuAz400 mentioned this pull request Nov 1, 2024
Open
@satya-CK satya-CK mentioned this pull request Nov 1, 2024
Open
@prestokp prestokp mentioned this pull request Nov 1, 2024
Open
@jageshwarsharma jageshwarsharma mentioned this pull request Nov 1, 2024
Open
@rbeal1227 rbeal1227 mentioned this pull request Nov 1, 2024
Open
@Ansh063 Ansh063 mentioned this pull request Nov 1, 2024
Open
@nekwonnah nekwonnah mentioned this pull request Nov 1, 2024
Open
@Harshith5346 Harshith5346 mentioned this pull request Nov 1, 2024
Open
@sayalikorade sayalikorade mentioned this pull request Nov 1, 2024
Open
@charuhasofc charuhasofc mentioned this pull request Nov 1, 2024
Open
@hanan7-dev hanan7-dev mentioned this pull request Nov 1, 2024
Open
@ShatakshiYD ShatakshiYD mentioned this pull request Nov 1, 2024
Open
@sahil32s sahil32s mentioned this pull request Nov 1, 2024
Open
@saurabhg-deloitte saurabhg-deloitte mentioned this pull request Nov 1, 2024
Open
@adykrak adykrak mentioned this pull request Nov 1, 2024
Open
@gauagrawal gauagrawal mentioned this pull request Nov 2, 2024
Open
@gegrant28 gegrant28 mentioned this pull request Nov 2, 2024
Open
@Cibbin Cibbin mentioned this pull request Nov 2, 2024
Open
@Kakarott-SS Kakarott-SS mentioned this pull request Nov 2, 2024
Open
@aanchalHkd aanchalHkd mentioned this pull request Nov 2, 2024
Open
@Sangram99-hacker Sangram99-hacker mentioned this pull request Nov 2, 2024
Open
@joh748 joh748 mentioned this pull request Nov 4, 2024
Open
@PriceUnknown PriceUnknown mentioned this pull request Nov 8, 2024
Open
@OyegokeTomisin OyegokeTomisin mentioned this pull request Nov 10, 2024
Open
@DevOpCar DevOpCar mentioned this pull request Nov 10, 2024
Open
@UgoOluwa UgoOluwa mentioned this pull request Nov 10, 2024
Open
@audreynieketien audreynieketien mentioned this pull request Nov 12, 2024
Open
sdurham
sdurham reviewed Jan 8, 2025
View reviewed changes
adm-zip.js
addLocalFolderAsync2: function (/*String*/ options, /*Function*/ callback) {
const self = this;
options = typeof options === "object" ? options : { localPath: options };
localPath = pth.resolve(fixPath(options.localPath));
Copy link

@sdurham sdurham Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

localPath is not defined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sdurham sdurham sdurham left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@5saviahv @sdurham