Skip to content

[CW2-12] Underline and button animations #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 11, 2024
Merged

[CW2-12] Underline and button animations #34

merged 3 commits into from
Oct 11, 2024

Conversation

@Domin0de
Copy link
Member

@Domin0de Domin0de commented Oct 11, 2024

Why the changes are required?

To make the page look nice

Changes

  • Added underline animation on CSE school link
  • Added size increase animations on various buttons

@Domin0de Domin0de requested a review from derekxu04 October 11, 2024 07:51
derekxu04
derekxu04 approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@derekxu04 derekxu04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the animations

@derekxu04 derekxu04 merged commit 704cc9e into master Oct 11, 2024
2 checks passed
@derekxu04 derekxu04 deleted the CW2-12-add-animations branch October 11, 2024 08:02
@Domin0de Domin0de restored the CW2-12-add-animations branch October 11, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@derekxu04 derekxu04 derekxu04 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Domin0de @derekxu04