Skip to content

[CW2-49] Fix up sponsors display #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 11, 2024
Merged

[CW2-49] Fix up sponsors display #31

merged 3 commits into from
Oct 11, 2024

Conversation

@chlowoee
Copy link
Contributor

@chlowoee chlowoee commented Sep 20, 2024 •
edited
Loading

Why the changes are required?

To improve the visual appeal of the Sponsor's page and standardise the assets with uniform sizing and white text.

Changes

  • Removed the SPONSORS page title
  • Centered the subtitles
  • Removed the coloured background of the text boxes
  • Updated the background colour of the modal to match the colour palette
  • Standardised the assets (400px x 150px, white text)

Screenshots

Before
image
image

After
image
image

Comments

@derekxu04
Copy link
Contributor

derekxu04 commented Oct 11, 2024

Really nice work!

Some changes (that I can do):

  • thicker border
  • have separate tiktok logo for footer
  • change a bit of the margins on the sponsors page

Otherwise really looks good

@derekxu04 derekxu04 self-requested a review October 11, 2024 07:56
derekxu04
derekxu04 approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@derekxu04 derekxu04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@Domin0de Domin0de merged commit 50d1961 into master Oct 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Domin0de Domin0de Domin0de approved these changes

+1 more reviewer

@derekxu04 derekxu04 derekxu04 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chlowoee @derekxu04 @Domin0de