Skip to content

Conversation

@csandman
Copy link
Owner

@csandman csandman commented Jun 6, 2022

  • Move @chakra-ui/system back into peer dependencies from normal dependencies
    • The goal behind this is to prevent duplicate versions of the @chakra-ui/system package from being installed, which was causing issues with theme colors being utilized properly
    • This was originally brought up in dark mode dropdown issues #135 and while I originally thought this was only an issue with using chakra-react-select@2 with @chakra-ui/react@1, I realized based on this comment that it is an issue in any situation in which there are multiple instances of @chakra-ui/system installed. I assume this is due to the color mode not being pulled properly from the main instance of @chakra-ui/system on the version installed with this package. Following the lead from Chakra's own sub-packages, I have moved @chakra-ui/system back into a peer dependency from a normal dependency to prevent this duplication.
    • The other Chakra packages may also be moved back into peer dependencies at some point, to prevent further package duplication, however these were originally moved into normal dependencies to prevent other issues. Ideally a third alternative will be found.
  • Update the rest of the packages:
 @babel/core                              ^7.17.10  →   ^7.18.2     
 @babel/plugin-proposal-class-properties   ^7.16.7  →  ^7.17.12     
 @babel/preset-env                        ^7.17.10  →   ^7.18.2     
 @babel/preset-react                       ^7.16.7  →  ^7.17.12     
 @babel/preset-typescript                  ^7.16.7  →  ^7.17.12     
 @types/react                              ^18.0.9  →  ^18.0.12     
 @typescript-eslint/eslint-plugin          ^5.23.0  →   ^5.27.0     
 @typescript-eslint/parser                 ^5.23.0  →   ^5.27.0     
 concurrently                               ^7.1.0  →    ^7.2.1     
 eslint                                    ^8.15.0  →   ^8.17.0     
 eslint-plugin-react                       ^7.29.4  →   ^7.30.0     
 lint-staged                               ^12.4.1  →   ^13.0.0     
 typescript                                 ^4.6.4  →    ^4.7.3  

Update remaining packages
@csandman csandman requested a review from jonahallibone June 6, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants