cpu_set should be constant by logic and by other distributions #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As I beleive __sched_cpucount should come with const, because it doesn't change it.
This brokes build that holds cpu_count mask in a class and trying to use CPU_COUNT macro inside the constant method
class Dummy
{
private:
cpu_set_t mask;
public:
int get_cpu_count () const
{
return CPU_COUNT(&_mask);
}
};
PS sorry if I am proposing some stupid thing, but i checked, that it is like that in couple of modern linux distributions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I beleive __sched_cpucount should come with const-qualifier , because it doesn't change it.
This brakes builds that holds cpu_count mask in a class and trying to use CPU_COUNT macro inside the constant method
class Dummy
{
private:
cpu_set_t mask;
public:
int get_cpu_count () const
{
return CPU_COUNT(&mask);
}
};
PS. sorry if I am proposing some stupid thing, but I checked, that it is like that in couple of modern linux distributions.