Assertion marshal causes panic

[casimcdaniels]

Take any assertion, for example from samltest.id

Attempt to marshal the XML:
xml.Marshal(assertion)

This results in a panic error:
value method time.Time.MarshalText called using nil *Time pointer

[casimcdaniels]

After a little digging, it looks like this is caused by the AuthnStatement.SessionNotOnOrAfter time field not being able to be marshaled since it's a *time.Time.

[crewjam]

I'm not sure what is going on here. It looks like we have a test that verifies that SessionNotOnOrAfter can be serialized here. Can you provide any more details?

[casimcdaniels]

I'm not sure what is going on here. It looks like we have a test that verifies that SessionNotOnOrAfter can be serialized here. Can you provide any more details?

Been a bit since I looked at this, but I believe that only handles when SessionNotOnOrAfter is present in XML. When it is not there a panic happens. I will have to dig up the code to see for sure but I do remember something about the marshal implementation for that field being different than other time fields within the xml.