[WIP] Initial PR for consuming gvproxy/macadam/cloud-init for crc-ng #5025
Conversation
This will help to use gvproxy as filename instead gvproxy-linux-amd64
Since with self sufficient bundle and cloud-init metadata pull secret should be applied automatic so just verify it instead apply. If it is not there that means something wrong with pull secret service in the bundle.
This helper can use to check if net cap is part of a binary or not for linux and implement no-ops for win and darwin
This will help to bind ports which are <1024 in Linux.
This commit have following - macadam helper to provide value based on macadam command run - cloud init helper to create user metadata - remove of libmachine api - updating vsock to work with gvproxy socket - Some todo which need to be improved
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@praveenkumar: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
No description provided.