Improve buffer reuse. Check for out of memory error code #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes crazyxman#80 - simdjson_is_valid() and other PHP functions would previously return false when out of memory - Related to crazyxman#60 - other php apis (using emalloc instead) will also emit fatal errors when out of memory and end the process. Closes crazyxman#79 - reuse buffers for strings less than 1000000 bytes and 100000 depth. (Assumes the depth rarely changes in callers)
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #80 - simdjson_is_valid() and other PHP functions would previously return false when out of memory
Closes #79 - reuse buffers for strings less than 1000000 bytes and 100000 depth. (Assumes the depth rarely changes in callers)
(Otherwise, create a brand new parser instance and only use that instance once, after which the megabytes of memory will be reclaimed)