Skip to content

Conversation

@surister
Copy link
Member

Summary of the changes / Why this is an improvement

Checklist

  • Link to issue this PR refers to (if applicable):
  • CLA is signed

@surister surister requested a review from amotl April 16, 2024 14:29
Copy link
Member

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Using active voice would be cool for docs and prose on future occasions. Here, this can also happen on a subsequent iteration.

@surister
Copy link
Member Author

Thanks. Using active voice would be cool for docs and prose on future occasions. Here, this can also happen on a subsequent iteration.

Thanks, I re-pushed a new version, hopefully it's better now.

@surister surister merged commit b1abdfa into crate:master Apr 16, 2024
@amotl
Copy link
Member

amotl commented Apr 16, 2024

Excellent. 💯

assert wordcount("we") == 0

Thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants