Close urllib3 pool before swapping the server into the "inactive" list #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
force-pushed
the
amo/improve-serverpool
branch
from
177bc91 to
de05334
Compare
amotl
force-pushed
the
amo/improve-serverpool
branch
from
de05334 to
e53335a
Compare
amotl
force-pushed
the
amo/improve-serverpool
branch
from
e53335a to
e29f799
Compare
This will hopefully resolve some flakyness where the swapping on the bookeeping between the list of active/inactive servers occurs too quickly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
while working on the test suite, I found a glitch, maybe unnoticed more often than not, where active connections have not been closed before removing them from the list of active servers.
With kind regards,
Andreas.