-
Notifications
You must be signed in to change notification settings - Fork 1
refactor(randwords): remove #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, I support the removal, though there's a stray 'endif' removed that is not related; I didn't check if that affects compilation, but I expect it would.
This was unused, and the word list needed better filtering to be viable.
41d6c13
to
49a2922
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @drraid you had some ideas how to generate better password for co-sign vs base64. Not sure if cleaning up random words to use for password generator in chalk would make more sense
Why is base 64 a problem?
…On Wed, Apr 3, 2024 at 10:53 AM Miroslav Shubernetskiy < ***@***.***> wrote:
***@***.**** commented on this pull request.
cc @drraid <https://github.com/drraid> you had some ideas how to generate
better password for co-sign vs base64. Not sure if cleaning up random words
to use for password generator in chalk would make more sense
—
Reply to this email directly, view it on GitHub
<#64 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABELGQNPU3WYC6EIVOT36Z3Y3QJVLAVCNFSM6AAAAABD7WH5RGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNZXGA4DGOJQGQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
I think @drraid comment came out of the chalk messaging:
writing down base64 is not ideal I think vs a collection of words so it was mostly a UX thing, not a security issue but he can comment better on his thoughts |
It would take 5 minutes to migrate to a smaller wordlist with an RFC behind
it. Might make sense to do; I’m stuck in meetings but maybe later
afternoon will hit you up on slack.
…On Wed, Apr 3, 2024 at 10:58 AM Miroslav Shubernetskiy < ***@***.***> wrote:
I think @drraid <https://github.com/drraid> comment came out of the chalk
messaging:
https://github.com/crashappsec/chalk/blob/66a5bb4b979e9b94f881abf929363db164cba975/src/attestation/embed.nim#L24-L28
Write this down. In future chalk commands, you will need
to provide it via CHALK_PASSWORD environment variable.
writing down base64 is not ideal I think vs a collection of words so it
was mostly a UX thing, not a security issue but he can comment better on
his thoughts
—
Reply to this email directly, view it on GitHub
<#64 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABELGQKVARG5XXH6VAMNIFLY3QKKFAVCNFSM6AAAAABD7WH5RGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZUHA2TKOJTHA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
If we did want to move to a smaller wordlist instead, the EFF wordlists are pretty good for some applications:
|
This was unused, and the word list needed better filtering to be viable.