Rename HAVE_CONFIG_H

[thetic]

Address #1829.

I know roughly nothing about autoconf, so please double check my work.

[coveralls]

coverage: 99.281%. remained the same
when pulling 8679b2d on thetic:dont_have_config_h
into 4700e91 on cpputest:master.

[basvodde]

Whoa....

[basvodde]

After a bit more checking on this, perhaps we can try out AX_PREFIX_CONFIG_H in the configure.ac.

My AI friend recommended to do this:
AC_CONFIG_HEADERS([config.h:config.hin], [AM_CPPFLAGS="$AM_CPPFLAGS -DCPPUTEST_HAVE_CONFIG_H"])

Which also feels like a hack... but at least a hack in the right place as this really shouldn't be in the am file :)

[thetic]

After a bit more checking on this, perhaps we can try out AX_PREFIX_CONFIG_H in the configure.ac.

I tried this and it only appears to affect the name of the resulting header, not the macro.

My AI friend recommended to do this:
AC_CONFIG_HEADERS([config.h:config.hin], [AM_CPPFLAGS="$AM_CPPFLAGS -DCPPUTEST_HAVE_CONFIG_H"])

I'll need to double check, but I think this only adds the CPPUTEST_HAVE_CONFIG_H macro; it doesn't remove the HAVE_CONFIG_H macro which we don't want leaking into other libraries.

[thetic]

My AI friend recommended to do this:
AC_CONFIG_HEADERS([config.h:config.hin], [AM_CPPFLAGS="$AM_CPPFLAGS -DCPPUTEST_HAVE_CONFIG_H"])

That doesn't build. I tried AC_CONFIG_HEADERS([config.h], [AM_CPPFLAGS="$AM_CPPFLAGS -DCPPUTEST_HAVE_CONFIG_H"]) and confirmed that defines only HAVE_CONFIG_H with DEFS = -DHAVE_CONFIG_H in the generated makefile.

[basvodde]

Ok, thanks for checking. I did some more checking, and I tried the following in the configure.ac:

-AC_CONFIG_HEADERS([config.h])
+AC_CONFIG_HEADERS([CppUTestGeneratedConfig.h])

In a quick test, that seems to do the trick. But I didn't checked in throughly yet. Could you check that?

[thetic]

that does not work. The name of HAVE_CONFIG_H is hardcoded in autoconf¹². I don't think config headers were ever intended to be exposed in libraries' public interfaces.

Footnotes

1. https://www.gnu.org/software/autoconf/manual/autoconf-2.61/html_node/Configuration-Headers.html ↩

2. https://github.com/autotools-mirror/autoconf/blob/8ac9edd1a71fe24ed94d70f1669e4fd6a81fa585/lib/autoconf/status.m4#L1267 ↩