P3914R0 Assorted NB comment resolutions for Kona 2025 #8527
+109
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes NB US 160-260 (C++26 CD).
Fixes NB US 209-332 (C++26 CD).
Fixes NB US 228-348 (C++26 CD).
Fixes NB US 263-396 (C++26 CD).
Fixes NB US 265-398 and US 266-399 (C++26 CD).
Fixes NB US 112-172 (C++26 CD).
Fixes NB US 130-193 (C++26 CD).
timsong-cpp
suggested changes
Nov 16, 2025
| For a nonempty range, eliminates all but the first element | ||
| from every consecutive group of equivalent elements referred to | ||
| Eliminates all elements referred to | ||
| by the iterator \tcode{i} in the range \range{first + 1}{last} |
Contributor
There was a problem hiding this comment.
Suggested change
| by the iterator \tcode{i} in the range \range{first + 1}{last} | |
| by the iterator \tcode{i} in the range \range{first}{last} |
| for which $E(\tcode{i})$ holds | ||
| Copies only the first $N$ elements | ||
| referred to by the iterator \tcode{i} in the range \range{first}{last} | ||
| for which $E(\tcode{i})$ is \tcode{true} |
Contributor
There was a problem hiding this comment.
Suggested change
| for which $E(\tcode{i})$ is \tcode{true} | |
| for which $E(\tcode{i})$ is \tcode{false} |
| Each such exception object is of an unspecified type | ||
| such that a \grammarterm{handler} of type \tcode{exception} | ||
| matches\iref{except.handle} the exception object | ||
| but a handler of type \tcode{dependent_sender_error} does not. |
Contributor
There was a problem hiding this comment.
Suggested change
| but a handler of type \tcode{dependent_sender_error} does not. | |
| but a \grammarterm{handler} of type \tcode{dependent_sender_error} does not. |
| of some most derived object \tcode{o} within its lifetime. | ||
| The lifetime of \tcode{o} does not end | ||
| as long as there exists a \tcode{shared_ptr} object \tcode{q} within its lifetime | ||
| such that \tcode{q.owner_equal(p)} is \tcode{true}. |
Contributor
There was a problem hiding this comment.
Suggested change
| such that \tcode{q.owner_equal(p)} is \tcode{true}. | |
| such that \tcode{q.owner_equal(p)} is \tcode{true}. |
| \begin{itemdescr} | ||
| \pnum | ||
| \expects | ||
| The ends of |
Contributor
There was a problem hiding this comment.
I'd move the of to the next line; ditto for the next two.
| the call is specified to produce a reflection of a type, | ||
| but $S$ would have no member named \tcode{type}; or | ||
| \item | ||
| the call is specified to return \tcode{S::value}, |
Contributor
There was a problem hiding this comment.
I guess here you want S in math font too to match the rest of the text?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8465.
Fixes NB US 160-260 (C++26 CD).