Skip to content

[LWG 1] P3504R0 C++ Standard Library Ready Issues #7459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 35 commits into from
Dec 16, 2024
Merged

[LWG 1] P3504R0 C++ Standard Library Ready Issues #7459

merged 35 commits into from
Dec 16, 2024

Conversation

burblebee
Copy link
Contributor

@burblebee burblebee commented Nov 28, 2024 •
edited by jensmaurer
Loading

Fixes #7413.

Notes: I assumed the Tentatively Ready issues were to be applied also.

Fixes cplusplus/papers#2165
Also fixes cplusplus/papers#1983
Also fixes cplusplus/papers#1811
Also fixes cplusplus/papers#1814

@burblebee burblebee marked this pull request as ready for review November 28, 2024 11:43
@jwakely
Copy link
Member

jwakely commented Nov 28, 2024

Notes: I assumed the Tentatively Ready issues were to be applied also.

Yes: "Apply the changes for all Ready and Tentatively Ready issues in P3504R0 (C++ Standard Library Ready Issues to be moved in Wrocław, Nov. 2024) to the C++ working paper."

@jensmaurer jensmaurer added this to the post-2024-11 milestone Dec 4, 2024
CaseyCarter
CaseyCarter reviewed Dec 9, 2024
View reviewed changes
jwakely
jwakely reviewed Dec 13, 2024
View reviewed changes
jwakely
jwakely reviewed Dec 13, 2024
View reviewed changes
@jensmaurer jensmaurer added the changes requested Changes to the wording or approach have been requested and not yet applied. label Dec 13, 2024
jwakely
jwakely reviewed Dec 13, 2024
View reviewed changes
source/containers.tex

// bit reference
class @\libmember{reference}{vector<bool>}@ {
constexpr reference() noexcept;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, the friend declarations were removed by #6427

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, appreciated!

jwakely
jwakely reviewed Dec 13, 2024
View reviewed changes
jwakely
jwakely requested changes Dec 13, 2024
View reviewed changes
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move two occurrences of "only" to later in the sentence, for more goodly Englishing.

Change address to to_address.

Use \libconcept for same_as, twice

jwakely
jwakely reviewed Dec 14, 2024
View reviewed changes
@tkoeppe tkoeppe force-pushed the motions-2024-11-lwg-1 branch from 7820989 to 6b52bff Compare December 16, 2024 02:27
jwakely
jwakely requested changes Dec 16, 2024
View reviewed changes
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've now added suggestions for the remaining issues. Those could be committed directly to the branch, or squashed individually to the relevant commits.

@tkoeppe tkoeppe force-pushed the motions-2024-11-lwg-1 branch 2 times, most recently from 0898ed1 to 3a057d4 Compare December 16, 2024 12:21
jwakely
jwakely reviewed Dec 16, 2024
View reviewed changes
@tkoeppe tkoeppe force-pushed the motions-2024-11-lwg-1 branch from 3a057d4 to af41385 Compare December 16, 2024 12:36
@burblebee @tkoeppe
LWG3899 co_yielding elements of an lvalue generator is unnecessarily …
a89d79c 
…inefficient
@burblebee @tkoeppe
LWG3900 The allocator_arg_t overloads of generator::promise_type::ope…
33d88c0 
…rator new should not be constrained
@burblebee @tkoeppe
LWG3918 std::uninitialized_move/_n and guaranteed copy elision
52cec15 
[specialized.algorithms.general] Changed to "function templates" as per #6265.
@burblebee @tkoeppe
LWG4014 LWG 3809 changes behavior of some existing std::subtract_with…
80e7c93 
…_carry_engine code
@burblebee @tkoeppe
LWG4024 Underspecified destruction of objects created in std::make_sh…
8a74ecf 
…ared_for_overwrite/std::allocate_shared_for_overwrite
@burblebee @tkoeppe
LWG4027 possibly-const-range should prefer returning const R&
a5e9c4a
@burblebee @tkoeppe
LWG4044 Confusing requirements for std::print on POSIX platforms
ce924b8 
[ostream.formatted.print] New paragraphs not numbered as indicated since they are part of the \effects clause.
@burblebee @tkoeppe
[ostream.formatted.print, print.fun] Move "only" to a clearer place
3bd0db6 
In wording for LWG4044, as per LWG discussion.
@burblebee @tkoeppe
LWG4064 Clarify that std::launder is not needed when using the result…
245bf7e 
… of std::memcpy
@burblebee @tkoeppe
LWG4072 std::optional comparisons: constrain harder
fbbfbcb
@tkoeppe tkoeppe force-pushed the motions-2024-11-lwg-1 branch from af41385 to 20aa7ce Compare December 16, 2024 12:45
@burblebee @tkoeppe
LWG4164 Missing guarantees for forward_list modifiers
3637c13
@burblebee @tkoeppe
LWG3216 Rebinding the allocator before calling construct/destroy in a…
2abba45 
…llocate_shared
@burblebee @tkoeppe
LWG3886 Monad mo' problems
6082785 
[optional.assign] Removed "<T>" from declaration to match that in synopsis.
@burblebee @tkoeppe
LWG4084 std::fixed ignores std::uppercase
4afe797
@burblebee @tkoeppe
LWG4088 println ignores the locale imbued in std::ostream
033df23
@burblebee @tkoeppe
LWG4113 Disallow has_unique_object_representations<Incomplete[]>
bc9e865
@burblebee @tkoeppe
LWG4119 generator::promise_type::yield_value(ranges::elements_of<R, A…
62b187f 
…lloc>)'s nested generator may be ill-formed
@burblebee @tkoeppe
LWG4124 Cannot format zoned_time with resolution coarser than seconds
10a3383
@burblebee @tkoeppe
LWG4126 Some feature-test macros for fully freestanding features are …
b9149a7 
…not yet marked freestanding
@burblebee @tkoeppe
LWG4135 The helper lambda of std::erase for list should specify retur…
f7b2b32 
…n type as bool
@burblebee @tkoeppe
LWG4140 Useless default constructors for bit reference types
baec71d 
[template.bitset.general] [vector.bool.pspc] bitset already removed.
@burblebee @tkoeppe
LWG4141 Improve prohibitions on "additional storage"
3abc16b
@burblebee @tkoeppe
LWG4142 format_parse_context::check_dynamic_spec should require at le…
7a54d69 
…ast one type
@burblebee @tkoeppe
LWG4144 Disallow unique_ptr<T&, D>
5fb4d20
@burblebee @tkoeppe
LWG4147 Precondition on inplace_vector::emplace
d6a8c67
@burblebee @tkoeppe
LWG4148 unique_ptr::operator* should not allow dangling references
7226952
@burblebee @tkoeppe
LWG4153 Fix extra "-1" for philox_engine::max()
6b9f90d
@burblebee @tkoeppe
LWG4157 The resolution of LWG3465 was damaged by P2167R3
ad3fd01
@burblebee @tkoeppe
LWG4169 std::atomic<T>'s default constructor should be constrained
d509d68
@tkoeppe tkoeppe force-pushed the motions-2024-11-lwg-1 branch from 20aa7ce to 5ce6b99 Compare December 16, 2024 12:56
@tkoeppe tkoeppe force-pushed the motions-2024-11-lwg-1 branch from 5ce6b99 to 71389a0 Compare December 16, 2024 17:21
@tkoeppe tkoeppe merged commit 6d81ed8 into main Dec 16, 2024
4 checks passed
@jensmaurer jensmaurer removed the changes requested Changes to the wording or approach have been requested and not yet applied. label Dec 16, 2024
@jensmaurer jensmaurer deleted the motions-2024-11-lwg-1 branch February 15, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jwakely jwakely jwakely requested changes

@tkoeppe tkoeppe tkoeppe left review comments

@jensmaurer jensmaurer jensmaurer left review comments

@CaseyCarter CaseyCarter Awaiting requested review from CaseyCarter

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

post-2024-11

5 participants

@burblebee @jwakely @CaseyCarter @tkoeppe @jensmaurer