Skip to content

[iterators] Improve indexing of defined terms. #3337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2019
Merged

[iterators] Improve indexing of defined terms. #3337

merged 1 commit into from
Nov 26, 2019

Conversation

jensmaurer
Copy link
Member

No description provided.

CaseyCarter
CaseyCarter approved these changes Oct 26, 2019
View reviewed changes
Copy link
Contributor

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The associated types "pointer type" and "reference type" of iterators are defined in [iterator.traits]/1; should this change cover them as well?

@W-E-Brown
Copy link
Contributor

As a drive-by, could we replace, in these revised definitions, "called" by "termed" or "known as"?

@zygoloid
Copy link
Member

Filed #3515 for the change that @W-E-Brown requested; we should make this change more broadly rather than as a drive-by for just these definitions.

@zygoloid zygoloid merged commit c78c224 into cplusplus:master Nov 26, 2019
@jensmaurer jensmaurer deleted the c8 branch November 26, 2019 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jensmaurer @W-E-Brown @zygoloid @CaseyCarter