Fix and simplify async coverage #549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoRossignoli
added
tenet-coverage
petli
reviewed
Sep 16, 2019
petli
approved these changes
Sep 18, 2019
|
Hmm ... I get now false positive uncovered branches like this:
|
|
Could be similar to #669? |
|
@MarcoRossignoli I'm not sure, because I don't use the new C# 8 Also, (atm.) I see no pattern ... it doesn't happen in every
|
|
Ok if you can repro let me know here there is current tested case https://github.com/tonerdo/coverlet/blob/master/test/coverlet.core.tests/Samples/Instrumentation.AsyncAwait.cs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #113
Today to avoid false positive on async state machines we remove "possible" async unvisited branches.
BTW they're not "real" user code branches, but are generated by async state machine.
With this PR we simplify async/await coverage skipping "compiler generated" branches.
cc: @tonerdo @petli @Rjae(check non called async+continuation) and also @SteveGilham because is expert and could argue the idea.