Feat/add multiple threshold #379 #1123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@MarcoRossignoli can you please validate? |
MarcoRossignoli
added
driver-console
MarcoRossignoli
requested changes
Mar 14, 2021
|
@pbmiguel seems that rebase didn't go well...I see 22 files changed you've included some old commits. |
pbmiguel
force-pushed
the
feat/add-multiple-threshold
branch
from
3d665db to
356bf27
Compare
|
@MarcoRossignoli, it's fixed now. You can see the new changes here |
daveMueller
reviewed
Mar 21, 2021
pbmiguel
force-pushed
the
feat/add-multiple-threshold
branch
from
356bf27 to
b8111fc
Compare
daveMueller
reviewed
Mar 22, 2021
pbmiguel
force-pushed
the
feat/add-multiple-threshold
branch
from
b8111fc to
99cb653
Compare
|
thanks @pbmiguel! |
|
@MarcoRossignoli, when will you expected this to be released? because the last release was in February |
|
We don't have ETA yet, need to schedule, I'll take a look at issue list to understand if we want more fix before release, anyway you can dogfood our nighty build if you want, so you'll help us with testing also https://github.com/coverlet-coverage/coverlet/blob/master/Documentation/ConsumeNightlyBuild.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Me and @FranciscoSousaDeveloper tried to continue this Pull Request but we had no permission. So this Pull Request is the continuation of #385 with rebase and updated documentation.
Basically, this Pull Request enables the specification of multiple threshold values.