Add coverage-reporter-platform input option
#233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure-specific version of coverage-reporter is downloaded and run by the github-action. Since this optionis not available for MacOS or Windows, we will deliver warning messages if the option is set, but continue processing with default behaviour. We have also stepped back from the previous implementation of the exception for coverage-reporter-version on MacOS and have turned that error message + exit code 1 into a warning message, allowing processing to proceed. We have also added tests to test different values for coverage-reporter-platform.
…s selected; just deliver a warning message and proceed with the default platform, x86_64.
…d by coverage-reporter-platform.
… the variable, platform_filename.
…es available and different contents of coveralls-checksums.txt from version v0.6.15 forward and be backwards compatible with versions <= v0.6.14.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #218
Description
Since we have added support for
coverage-reporteronaarch64, we need to provide users of ourgithub-actionthe ability to select this architecture-specific version ofcoverage-reporterwhen on anaarch64/arm64runner.To Do
coverage-reporter-platforminput option to control which architecture-specific version of coverage-reporter is downloaded and run by the github-action. (Linux only.)coverage-reporter-versionon MacOS and have turned that error message + exit code 1 into a warning message, allowing processing to proceed.coverage-reporter-platform.