Skip to content

Add standard img tag attribute support. #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add standard img tag attribute support. #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3620bee
add support for all img tag attributes
Cleanshooter Jul 2, 2021
22adf68
add docs for imageClassName
Cleanshooter Jul 2, 2021
253ebcf
fix test issues
Cleanshooter Jul 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,12 @@
}
},
"rules": {
"prettier/prettier": "error",
"prettier/prettier": [
"error",
{
"endOfLine": "auto"
}
],
"arrow-body-style": [2, "always"],
"no-console": 0,
"no-param-reassign": 0,
Expand Down
55 changes: 50 additions & 5 deletions src/components/image/image.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,28 @@ import classnames from 'classnames';
import Element from '../element';

const Image = ({
// figure tag props
className,
fullwidth,
// img tag props
alt,
crossOrigin,
height,
ismap,
loading,
longdesc,
referrerpolicy,
sizes,
src,
srcSet,
useMap,
width,
// component props
size,
fallback,
rounded,
src,
fullwidth,
imageClassName,
// leftovers
...props
}) => {
const [state, setState] = useState({ src });
Expand All @@ -32,22 +47,49 @@ const Image = ({
})}
>
<img
className={classnames({
className={classnames(imageClassName, {
'is-rounded': rounded,
})}
onError={() => {
return state.src !== fallback && setState({ src: fallback });
}}
src={state.src}
alt={alt}
crossOrigin={crossOrigin}
height={height}
ismap={ismap}
loading={loading}
longdesc={longdesc}
referrerpolicy={referrerpolicy}
sizes={sizes}
srcSet={srcSet}
useMap={useMap}
width={width}
/>
</Element>
);
};

Image.propTypes = {
src: PropTypes.string.isRequired,
fullwidth: PropTypes.bool,
alt: PropTypes.string,
crossOrigin: PropTypes.oneOf(['anonymous', 'use-credentials']),
height: PropTypes.string,
ismap: PropTypes.bool,
loading: PropTypes.oneOf(['eager', 'lazy']),
longdesc: PropTypes.string,
referrerpolicy: PropTypes.oneOf([
'no-referrer',
'no-referrer-when-downgrade',
'origin',
'origin-when-cross-origin',
'unsafe-url',
]),
sizes: PropTypes.string,
src: PropTypes.string.isRequired,
srcSet: PropTypes.string,
useMap: PropTypes.string,
width: PropTypes.string,
rounded: PropTypes.bool,
size: PropTypes.oneOfType([
PropTypes.oneOf([
Expand Down Expand Up @@ -79,7 +121,10 @@ Image.propTypes = {
PropTypes.string,
]),
fallback: PropTypes.string,
fullwidth: PropTypes.bool,
/**
* Applies additional classes to the `img` tag (standard `className` applies to root element)
*/
imageClassName: PropTypes.string,
renderAs: PropTypes.oneOfType([
PropTypes.func,
PropTypes.string,
Expand Down