Skip to content

RCBC-468: Support for maxTTL value of -1 for collection 'no expiry' #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DemetrisChr merged 1 commit into from
Jan 18, 2024
Merged

RCBC-468: Support for maxTTL value of -1 for collection 'no expiry' #130

DemetrisChr merged 1 commit into from
Jan 18, 2024

Conversation

@DemetrisChr
Copy link
Contributor

@DemetrisChr DemetrisChr commented Jan 11, 2024

  • Change conversions of max_expiry from Ruby to C++ and vice versa to take into account that max_expiry is now a signed integer in the collections API
  • Raise an InvalidArgument error if max_expiry is less than -1
  • Add tests for setting max_expiry to -1 and for invalid values in both update_collection and create_collection

@DemetrisChr DemetrisChr requested a review from avsej January 11, 2024 14:27
@DemetrisChr DemetrisChr merged commit 3423b68 into couchbase:main Jan 18, 2024
@DemetrisChr DemetrisChr deleted the RCBC-468-ttl-minus-1 branch January 18, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avsej avsej avsej approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DemetrisChr @avsej