feat: support unordered txs #686
Open
+176
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ransaction building
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Allow for EVM txs to utilize the unordered tx feature of the SDK. It works by essentially mimicking and using the same values/fields as the native
SigVerificationDecorator.IncrementNonceto be a method onMonoDecoratorIncrementNonceto consider unordered txsBuildTxWithFactoryonMsgEthereumTxNote:
mainif this is approved.tx evm raware supported. In other words, EVM txs that are intercepted via the EVM JSON RPC (and mempool?) do not support setting unordered values. There is no way, AFAIK, that allows for granular setting of custom tx fields via the RPC. If there is a clean approach, we can do that in a future separate PR.